Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the engine configuration to work consistently with omniauth #15

Closed
olivierobert opened this issue Mar 28, 2018 · 0 comments
Closed

Improve the engine configuration to work consistently with omniauth #15

olivierobert opened this issue Mar 28, 2018 · 0 comments
Labels
priority : high type : bug
Projects
1.0.0

Comments

@olivierobert
Copy link
Member

Currently, omniauth breaks in the dev/test environment when code is reloaded. It fails with an error related to the fact that the user model is not omniauthable.

The issue has been resolved in a PR for Athena. So these improvements need to be added to the gem 💪
@olivierobert olivierobert created this issue from a note in 1.0.0 (To Do) Mar 28, 2018
@olivierobert olivierobert mentioned this issue Feb 24, 2019
Merged
1.0.0 automation moved this from To Do to Done Mar 4, 2019
olivierobert added a commit that referenced this issue Mar 4, 2019
@olivierobert
Fix: Improve the engine configuration to work consistently with omnia…
46db83b 
…uth (#19)

Closes #15 

## What happened

Revisit and improve the way the engine extends the main application. 
 
## Insight

* Using `concerns` instead of `module_eval` to extend the models in the main app
* Expanded the default handling of the omniauth callbacks to make it more production-ready 
 
## Proof Of Work

This setup has been used in two project: `athena-web` and `vcliq-web`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority : high type : bug
Projects
No open projects
1.0.0
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@olivierobert