Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a Rubocop cop for ordering instructions in class (e.g. Models) #499

Closed
Goose97 opened this issue Jan 5, 2024 · 0 comments · Fixed by #509
Closed

Create a Rubocop cop for ordering instructions in class (e.g. Models) #499

Goose97 opened this issue Jan 5, 2024 · 0 comments · Fixed by #509
Assignees
@Goose97
Labels
type : feature

Comments

@Goose97
Copy link
Contributor

Goose97 commented Jan 5, 2024 •
edited
Loading

Why

We have a comprehensive set of style guides in the Compass. Sometimes, it hard to keep them all of your head why developing. Turning it into a custom Rubocop rules can lower the cognitive overhead

  • Implement a custom Rubocop to validate instructions order for class (e.g. Models)

Who Benefits?

Developers on standard admin projects.
@Goose97 Goose97 self-assigned this Jan 5, 2024
Goose97 added a commit that referenced this issue Mar 29, 2024
@Goose97
[#499] Implement custom Rubocop rule to enforce class template
3867d5e
@Goose97 Goose97 mentioned this issue Mar 29, 2024
Merged
Goose97 added a commit that referenced this issue Mar 29, 2024
@Goose97
[#499] Implement custom Rubocop rule to enforce class template
b764864
Goose97 added a commit that referenced this issue Mar 29, 2024
@Goose97
[#499] Implement custom Rubocop rule to enforce class template
a97057c
Goose97 added a commit that referenced this issue Mar 29, 2024
@Goose97
[#499] Implement custom Rubocop rule to enforce class template
cd1ed78
Goose97 added a commit that referenced this issue Mar 29, 2024
@Goose97
[#499] Implement custom Rubocop rule to enforce class template
15d8ddf
Goose97 added a commit that referenced this issue Mar 29, 2024
@Goose97
[#499] Implement custom Rubocop rule to enforce class template
02a7f5c
Goose97 added a commit that referenced this issue Mar 29, 2024
@Goose97
[#499] Implement custom Rubocop rule to enforce class template
cea6883
Goose97 added a commit that referenced this issue Mar 29, 2024
@Goose97
[#499] Implement custom Rubocop rule to enforce class template
3060df5
Goose97 added a commit that referenced this issue Mar 29, 2024
@Goose97
[#499] Implement custom Rubocop rule to enforce class template
be94524
Goose97 added a commit that referenced this issue Mar 29, 2024
@Goose97
[#499] Implement custom Rubocop rule to enforce class template
64e481d
Goose97 added a commit that referenced this issue Apr 9, 2024
@Goose97
[#499] Replace pluck with map
8b5fce5
Goose97 added a commit that referenced this issue Apr 9, 2024
@Goose97
[#499] Improve error message
d8385eb
Goose97 added a commit that referenced this issue Apr 9, 2024
@Goose97
[#499] Improve error message
da7c883
Goose97 added a commit that referenced this issue Apr 9, 2024
@Goose97
[#499] Improve error message
54e41c8
Goose97 added a commit that referenced this issue Apr 9, 2024
@Goose97
[#499] Improve error message
f9fe5e6
Goose97 added a commit that referenced this issue Apr 11, 2024
@Goose97
[#499] Implement custom Rubocop rule to enforce class template
68072cb
Goose97 added a commit that referenced this issue Apr 11, 2024
@Goose97
[#499] Replace pluck with map
a018134
Goose97 added a commit that referenced this issue Apr 11, 2024
@Goose97
[#499] Improve error message
0eece68
Goose97 added a commit that referenced this issue Apr 11, 2024
@Goose97
[#499] Fix linter errors
b80b449
Goose97 added a commit that referenced this issue Apr 11, 2024
@Goose97
[#499] Ignore custom rubocop code while running Rubocop on generated …
18fde8b 
…projects
Goose97 added a commit that referenced this issue Apr 11, 2024
@Goose97
[#499] Ignore custom rubocop code while running Rubocop on generated …
6b91a81 
…projects
github-merge-queue bot pushed a commit that referenced this issue Apr 29, 2024
@Goose97
[#499] Create a Rubocop cop for ordering instructions in class (e.g. …
0102560 
…Models) (#509)

* [#499] Implement custom Rubocop rule to enforce class template

* [#499] Replace pluck with map

* [#499] Improve error message

* [#499] Fix linter errors

* [#499] Ignore custom rubocop code while running Rubocop on generated projects
@malparty malparty mentioned this issue May 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Goose97 Goose97

Labels
type : feature
Projects
None yet
Milestone
No milestone
1 participant
@Goose97