Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rails to v6.1.3.1 #287

Merged
merged 1 commit into from Apr 8, 2021

Conversation

longnd
Copy link
Contributor

@longnd longnd commented Apr 2, 2021

What happened

Update Rails to the latest stable version v6.1.3.1 to avoid the issue of failing to start because of yanked dependency.

Insight

Rails depends on the MimeMagic gem (ActionMailbox -> ActiveStorage -> Marcel -> Mimemagic). But that gem recently yanked all v0.3.x versions, making the new Rails apps fail to start and the old ones fail to rebuild. Mimemagic also released new versions but changed the Licence from MIT -> GPL2 which isn't compatible with Rails' license anymore.
Rails release a new version v6.1.3.1 to solve that issue by removing Mimemagic dependency.

Proof Of Work

Nimble CX after upgrading to this version no longer experience the failed build due to mimemagic gem.

@longnd longnd added this to the 4.4.0 milestone Apr 2, 2021
@longnd longnd self-assigned this Apr 2, 2021
@longnd longnd requested a review from a team April 2, 2021 03:45
Copy link
Member

@andyduong1920 andyduong1920 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @longnd.

A small comment, let update the README too :)

@longnd longnd force-pushed the chore/update-rails-to-latest-version branch from acd00d5 to 2d54580 Compare April 2, 2021 03:53
@longnd
Copy link
Contributor Author

longnd commented Apr 2, 2021

A small comment, let update the README too :)

Updated in 2d54580.

@andyduong1920 andyduong1920 merged commit 9f41831 into develop Apr 8, 2021
@ankitkalia1195 ankitkalia1195 mentioned this pull request May 7, 2021
@malparty malparty deleted the chore/update-rails-to-latest-version branch July 22, 2022 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants