Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move some dependencies to devDependencies #123

Closed
rosle opened this issue Sep 8, 2022 · 0 comments · Fixed by #124
Closed

Move some dependencies to devDependencies #123

rosle opened this issue Sep 8, 2022 · 0 comments · Fixed by #124
Assignees
@rosle
Labels
type : chore
Milestone
3.1.0

Comments

@rosle
Copy link
Contributor

rosle commented Sep 8, 2022

Why

Right now most of the packages are installed as dependencies, but some could be moved out to devDependencies.

Who Benefits?

the template users ☺️
@rosle rosle self-assigned this Sep 8, 2022
rosle added a commit that referenced this issue Sep 8, 2022
@rosle
[#123] Move some dependencies to devDependencies
b034f06
@rosle rosle mentioned this issue Sep 8, 2022
Merged
@rosle rosle linked a pull request Sep 8, 2022 that will close this issue
[#123] Move some dependencies to devDependencies #124
Merged
rosle added a commit that referenced this issue Sep 8, 2022
@rosle
[#123] Improve github workflow
e113b53
rosle added a commit that referenced this issue Sep 8, 2022
@rosle
[#123] Remove unused Danger plugins
91fc424
rosle added a commit that referenced this issue Sep 8, 2022
@rosle
[#123] Move devDependencies next to the dependencies for readability
2fc8661
carryall added a commit that referenced this issue Sep 9, 2022
@carryall
Merge pull request #124 from nimblehq/chore/123-manage-depedencies-group
a9e875f 
[#123] Move some dependencies to devDependencies
@carryall carryall added this to the 3.1.0 milestone Sep 9, 2022
carryall pushed a commit that referenced this issue Oct 2, 2022
@rosle @carryall
[#123] Move some dependencies to devDependencies
0571938
carryall pushed a commit that referenced this issue Oct 2, 2022
@rosle @carryall
[#123] Remove unused Danger plugins
295cda6
carryall pushed a commit that referenced this issue Oct 2, 2022
@rosle @carryall
[#123] Move devDependencies next to the dependencies for readability
28a0c11
@carryall carryall mentioned this issue Oct 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rosle rosle

Labels
type : chore
Projects
None yet
Milestone
3.1.0
Development

Successfully merging a pull request may close this issue.

[#123] Move some dependencies to devDependencies nimblehq/react-templates
2 participants
@carryall @rosle