Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: [Bootstrap Add-on] Compilation errors #130

Closed
rosle opened this issue Sep 9, 2022 · 0 comments · Fixed by #132
Closed

Fix: [Bootstrap Add-on] Compilation errors #130

rosle opened this issue Sep 9, 2022 · 0 comments · Fixed by #132
Assignees
Milestone

Comments

@rosle
Copy link
Contributor

rosle commented Sep 9, 2022

Issue

After boostrapping the app with Bootstrap add-on, the app fails to compile.

  1. Missing the utilities variables
Failed to compile.

SassError: Undefined variable.
    ╷
142 │       values: $utilities-border-colors
    │               ^^^^^^^^^^^^^^^^^^^^^^^^
    ╵
  node_modules/bootstrap/scss/_utilities.scss 142:15      @import
  src/assets/stylesheets/vendor/bootstrap/index.scss 5:9  @use
  src/assets/stylesheets/application.scss 5:1             root stylesheet

On Bootstrap 5.2, There is a new bootstrap/scss/maps that we need to import. https://github.com/twbs/bootstrap/blob/46bb9e78d74e0c7f4fa6f6fa611f3d9f8f28860b/site/content/docs/5.2/customize/color.md#generating-utilities

Maybe it's also safer if we lock the version of the Bootstrap installed to avoid this kind of error 💡

  1. A warning of deprecated calculation outside calc()
<w> Deprecation Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.
<w> 
<w> Recommendation: math.div($value, $base-font-size) or calc($value / $base-font-size)
<w> 
<w> More info and automated migrator: https://sass-lang.com/d/slash-div
<w> 
<w> src/assets/stylesheets/functions/_sizing.scss 23:20  rem()
<w> src/dummy.scss 44:21                                 root stylesheet

Expected

The app should be compiled successfully.

Steps to reproduce

  1. Create a new app from the template
  2. Choose Bootstrap as a UI Framework
@rosle rosle self-assigned this Sep 9, 2022
carryall added a commit that referenced this issue Sep 20, 2022
[#130] Fix: [Bootstrap Add-on] Compilation errors
@bterone bterone added this to the 3.1.0 milestone Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants