Skip to content

Commit

Permalink
Standardizing global function calls by using root namespace.
Browse files Browse the repository at this point in the history
Adding missing class property list for Redis and Sqs classes.
  • Loading branch information
brentscheffler committed Jun 27, 2019
1 parent 8dffcb8 commit 6b9c050
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 5 deletions.
5 changes: 5 additions & 0 deletions src/PubSub/Redis.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@
use Predis\PubSub\DispatcherLoop;
use Syndicate\Message;

/**
*
* @property Client $client
*
*/
class Redis extends PubSubAbstract
{
/**
Expand Down
2 changes: 1 addition & 1 deletion src/Queue/MockQueue.php
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ public function put($data, array $options = []): void
*/
public function get(array $options = []): ?Message
{
$message = array_shift($this->messages);
$message = \array_shift($this->messages);

return new Message($this, $message, $this->deserialize($message));
}
Expand Down
4 changes: 2 additions & 2 deletions src/Queue/Queue.php
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,8 @@ public function getName(): string
* @param array $params
* @return mixed
*/
public function __call(string $method, array $params)
public function __call(string $method, array $params = [])
{
return call_user_func_array([$this->client, $method], $params);
return \call_user_func_array([$this->client, $method], $params);
}
}
5 changes: 5 additions & 0 deletions src/Queue/RedisPubSub.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@
use Predis\PubSub\DispatcherLoop;
use Syndicate\Message;

/**
*
* @property Client $client
*
*/
class RedisPubSub extends Queue
{
/**
Expand Down
4 changes: 2 additions & 2 deletions tests/MessageTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ public function test_get_source_message()
"body" => '{"event": "SomeEvent", "data": {"name": "Joe Example", "email": "joe@example.com"}}'
];

$message = new Message(new MockQueue('TestQueue'), $sourceMessage, json_decode($sourceMessage["body"]));
$message = new Message(new MockQueue('TestQueue'), $sourceMessage, \json_decode($sourceMessage["body"]));

$this->assertEquals($sourceMessage, $message->getSourceMessage());
}
Expand All @@ -31,7 +31,7 @@ public function test_get_payload()
"body" => '{"event": "SomeEvent", "data": {"name": "Joe Example", "email": "joe@example.com"}}'
];

$message = new Message(new MockQueue('TestQueue'), $sourceMessage, json_decode($sourceMessage["body"]));
$message = new Message(new MockQueue('TestQueue'), $sourceMessage, \json_decode($sourceMessage["body"]));

$this->assertEquals(json_decode($sourceMessage['body']), $message->getPayload());
}
Expand Down

0 comments on commit 6b9c050

Please sign in to comment.