Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix locks #3

Merged
merged 1 commit into from
Oct 5, 2022
Merged

Fix locks #3

merged 1 commit into from
Oct 5, 2022

Conversation

tobikris
Copy link
Member

The lock implementations were not correct. Locking was not done properly. This adds tests for the locking implementations and fixes the locking.

@tobikris tobikris requested a review from lu1as September 25, 2022 12:16
@tobikris tobikris force-pushed the fix-locks branch 3 times, most recently from 6dd3a01 to 5f420af Compare September 25, 2022 18:38
@tobikris tobikris force-pushed the fix-locks branch 4 times, most recently from 05b4cb5 to f0bac69 Compare October 5, 2022 13:46
Copy link
Member

@lu1as lu1as left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lu1as lu1as merged commit 3eccbb7 into main Oct 5, 2022
@lu1as lu1as deleted the fix-locks branch October 5, 2022 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants