Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to istanbul-api #496

Merged
merged 1 commit into from May 12, 2019
Merged

Upgrade to istanbul-api #496

merged 1 commit into from May 12, 2019

Conversation

riptl
Copy link
Contributor

@riptl riptl commented May 8, 2019

Pull request checklist

  • All tests pass. Demo project builds and runs.
  • I have resolved any merge conflicts.

What's in this pull request?

Replace istanbul (deprecated) with istanbul-api in package.json

Why?

gulpfile.js depends on istanbul-api, but currently only istanbul is imported.

const istanbul = require('istanbul-api');

"istanbul": "^1.1.0-alpha.1",

As a result, the build fails with package managers without flat node_modules (such as pnpm.js.org)

@codecov
Copy link

codecov bot commented May 8, 2019

Codecov Report

Merging #496 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #496      +/-   ##
==========================================
+ Coverage   70.39%   70.43%   +0.03%     
==========================================
  Files         201      201              
  Lines       12530    12530              
==========================================
+ Hits         8820     8825       +5     
+ Misses       3710     3705       -5
Impacted Files Coverage Δ
.../main/generic/consensus/full/FullConsensusAgent.js 58.91% <0%> (+0.49%) ⬆️
src/main/generic/consensus/InvRequestManager.js 81.08% <0%> (+10.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbbc406...c713f26. Read the comment docs.

@styppo styppo merged commit 0965361 into master May 12, 2019
@styppo styppo deleted the terorie/bump_istanbul branch May 12, 2019 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants