MacroSync #16
Merged
MacroSync #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 4, 2019
jgraef
reviewed
Nov 6, 2019
jgraef
reviewed
Nov 6, 2019
jgraef
reviewed
Nov 6, 2019
jgraef
reviewed
Nov 6, 2019
jgraef
reviewed
Nov 6, 2019
jgraef
reviewed
Nov 6, 2019
jgraef
reviewed
Nov 6, 2019
jgraef
reviewed
Nov 6, 2019
jgraef
reviewed
Nov 6, 2019
jgraef
reviewed
Nov 6, 2019
jgraef
suggested changes
Nov 6, 2019
|
Some are duplicate. I had close the browser and thought they were lost. |
Doesn't need fixing, but I will take care of the style issues. |
paberr
force-pushed
the
paberr/macrosync
branch
from
a47a6dc
to
b28797d
Compare
jgraef
force-pushed
the
paberr/macrosync
branch
from
b28797d
to
ea24cfa
Compare
jgraef
approved these changes
Nov 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the MacroSync protocol into the client.
I haven't integrated it with the config though, since @jgraef changed the config builder in one of his branches completely and I didn't want to do the work twice.
For now, it always uses the full sync client and the behaviour shouldn't be any different from the current one.
The main two TODOs, for which I will open issues after having merged this PR are:
Otherwise a client can send us any subset of the transactions and we will only find out that our vector doesn't give the correct hash when he is done sending us transactions.