Internally tag all web-client plain transaction data variants #2026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sisou
force-pushed
the
soeren/web-client-data
branch
from
0af38db
to
7d9bd12
Compare
sisou
added a commit
to nimiq/keyguard
that referenced
this pull request
Dec 1, 2023
… staking Remove hard-coded staking data types and instead use the Albatross client's data parsing capabilities. Requires nimiq/core-rs-albatross#2026 Enables signing of validator transactions (nimiq/hub#518).
sisou
added a commit
to nimiq/keyguard
that referenced
this pull request
Dec 1, 2023
… staking Remove hard-coded staking data types and instead use the Albatross client's data parsing capabilities. Requires nimiq/core-rs-albatross#2026 Enables signing of validator transactions (nimiq/hub#518).
jsdanielh
approved these changes
Dec 4, 2023
|
Rebasing it to merge it |
By specifying exactly which fields are expected, adding new fields creates a compiler error instead of being ignored.
jsdanielh
force-pushed
the
soeren/web-client-data
branch
from
7d9bd12
to
edcc223
Compare
sisou
added a commit
to nimiq/keyguard
that referenced
this pull request
Dec 12, 2023
… staking Remove hard-coded staking data types and instead use the Albatross client's data parsing capabilities. Requires nimiq/core-rs-albatross#2026 Enables signing of validator transactions (nimiq/hub#518).
sisou
added a commit
to nimiq/keyguard
that referenced
this pull request
Dec 12, 2023
… staking Remove hard-coded staking data types and instead use the Albatross client's data parsing capabilities. Requires nimiq/core-rs-albatross#2026 Enables signing of validator transactions (nimiq/hub#518).
sisou
added a commit
to nimiq/keyguard
that referenced
this pull request
Dec 12, 2023
… staking Remove hard-coded staking data types and instead use the Albatross client's data parsing capabilities. Requires nimiq/core-rs-albatross#2026 Enables signing of validator transactions (nimiq/hub#518).
sisou
added a commit
to nimiq/keyguard
that referenced
this pull request
Apr 29, 2024
… staking Remove hard-coded staking data types and instead use the Albatross client's data parsing capabilities. Requires nimiq/core-rs-albatross#2026 Enables signing of validator transactions (nimiq/hub#518).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
This PR adds a
typefield to all plain transaction data and proof variants in the web-client, to let users easily distinguish between data types. This will be especially helpful in our Keyguard to distinguish between staking transaction types, without having to hard-code the variant ID in the Keyguard. Experience showed that these IDs sometimes shifted, requiring manual updates. With this change, the update would be included in the client update.Pull request checklist
clippyandrustfmtwarnings.