Verify sender account type in mempool #2634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsdanielh
approved these changes
Jun 17, 2024
|
Is |
|
No, |
nibhar
approved these changes
Jun 18, 2024
| None | ||
| } | ||
| } | ||
|
|
||
| /// The given account must correspond to the sender of the given transaction. |
There was a problem hiding this comment.
Out of curiosity: what happens if it isn't?
The account type on the sender side is now properly checked in the mempool via `reserve_balance`. A mismatch on the recipient side will now result in a failed transaction, which brings it in line with other account type mismatches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The account type on the sender side is now properly checked in the mempool via
reserve_balance().The intrinsic staking contract account type check is removed entirely from the transaction verification. A mismatch on the recipient side will now result in a failed transaction, which brings it in line with other account type mismatches.
Closes #2605