validator-network: Improve logging #2668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsdanielh
force-pushed
the
jsdanielh/minor_fixes
branch
from
deb714d
to
776cce7
Compare
hrxi
reviewed
Jun 21, 2024
| @@ -128,11 +128,11 @@ where | |||
| Ok(peer_id) | |||
| } | |||
| Ok(None) => { | |||
| log::trace!(validator_id, %public_key, "Unable to resolve validator peer ID: Entry not found in DHT"); | |||
| log::debug!(validator_id, %public_key, "Unable to resolve validator peer ID: Entry not found in DHT"); | |||
There was a problem hiding this comment.
I think it'd be better to still log these messages the first time they appear, but stop logging them afterwards.
Improve `validator-network` logging by moving most of the recurring errors to `trace` and only log to `debug` when there is a change in the state of the cache.
jsdanielh
force-pushed
the
jsdanielh/minor_fixes
branch
from
776cce7
to
63a8c85
Compare
hrxi
approved these changes
Jun 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve
validator-networklogging by moving most of the recurring errors totraceand only log todebugwhen there is a change in the state of the cache.Pull request checklist
clippyandrustfmtwarnings.