Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New "Compact" layout for Nimiq Pay. UI updates. Bug fixes. #9

Merged
merged 8 commits into from
May 13, 2024
Merged

Conversation

onmax
Copy link
Member

@onmax onmax commented May 8, 2024

Changelog

New layout for Nimiq Pay

Using the query param ?layout=compact, we can activate the new UI for the Nimiq Pay application: https://deploy-preview-9--nimiq-map.netlify.app/?layout=compact

New FAQ modal

Since last month we have added almost 30K locations. The locations have been fetched automatically, but we have not verified them. Therefore, I think it is our responsibility to add a notice/warning. I thought we could do it in the form of a "FAQ" so we can add more content. https://deploy-preview-9--nimiq-map.netlify.app/?modal=faq

Moved Modals

The 'Add new location' and 'Report location' pages have been moved to their own modal instead of their own page.

See diff

Page Before After
New location image image
Report Location image image

Query params everywhere

Everything dynamic can be stored in query parameters: modal, language, location... This allows everything in the application to be copied and shared while maintaining the same state.

See all query params
Parameter Description Example Comments
Map position Position of the map https://map.nimiq.com/@{lat},{lng},{zoom}
uuid UUID of the location https://map.nimiq.com/?uuid={uuid} Don't use it with Map position if you don't know the coordinates of the location
Language Language of the app https://map.nimiq.com/?lang={language} Check supported languages`
Layout Layout of the app https://map.nimiq.com/?layout={layout} Check supported layouts
Modal Modal to show https://map.nimiq.com/?modal={modal} Check supported modals
Nested Modal Nest modal to show https://map.nimiq.com/?nested={nested} Check supported modals. Use it with modal
Search Search to show https://map.nimiq.com/?search={search}
Question Question to show https://map.nimiq.com/?q=q-1 Use it with faq modal

New Cryptocities design

When the user explores the map and is in a Cryptocity, we will display a new banner.

Expand to see details

Zoom out

image

Zoom in

image

New icons and Nimiq CSS library

  • With the new Nimiq icons, over 50 files of just icons have been deleted 🤘.
  • With the new Nimiq CSS, we achieve more consistency across applications and faster development.

Bug fixes

  • Before the first time you load the app, there was an error loading the captcha token

PS: You can open the settings modal (gear icon top left) and click on the logo with the shift key pressed 🤌

Copy link

netlify bot commented May 8, 2024

Deploy Preview for nimiq-map canceled.

Name Link
🔨 Latest commit 7d0ad34
🔍 Latest deploy log https://app.netlify.com/sites/nimiq-map/deploys/6641d9828358c70009ada201

@onmax onmax force-pushed the unocss branch 3 times, most recently from cc087fd to ba6498b Compare May 8, 2024 10:43
@sisou
Copy link
Member

sisou commented May 8, 2024

Preview doesn't work for me. Stuck on the flash screen. Console says something about TypeError: Cannot read properties of undefined (reading 'slice'), linking to code line

console.log(JSON.stringify({ captchaToken: `${captchaToken.slice(0, 10)}...`, uuid: `${data.captcha_uuid.slice(0, 10)}...` }));

specifically, data.captcha_uuid is undefined

@onmax
Copy link
Member Author

onmax commented May 8, 2024

Preview doesn't work for me. Stuck on the flash screen. Console says something about TypeError: Cannot read properties of undefined (reading 'slice'), linking to code line

console.log(JSON.stringify({ captchaToken: `${captchaToken.slice(0, 10)}...`, uuid: `${data.captcha_uuid.slice(0, 10)}...` }));

specifically, data.captcha_uuid is undefined

Should be ok now: deploy-preview-9--nimiq-map.netlify.app/

@onmax onmax requested a review from Albermonte May 8, 2024 12:32
@onmax onmax marked this pull request as ready for review May 8, 2024 12:59
@onmax onmax merged commit 49b1adc into main May 13, 2024
4 checks passed
@onmax onmax deleted the unocss branch May 14, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants