NIM-less Checkout #411
Merged
NIM-less Checkout #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danimoh
approved these changes
Apr 15, 2020
danimoh
approved these changes
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a configuration option
allowsCheckoutWithoutNim: (origin: string) => booleanthat returns if a given origin is allowed to create Checkout requests without a NimPaymentOption.For development, this is configured as always
trueby default, for the testnet this allows the CPL staging website, and for the mainnet this allows Checkout requests from non-API CPLs.The only two necessary changes are in
RequestParserlines 122-126, and inCheckout.vue, as the NIM currency is now not necessarily present anymore.