Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nimiq Checkout Point-of-Sale improvements #471

Merged
merged 11 commits into from
Oct 4, 2021
Merged

Conversation

sisou
Copy link
Member

@sisou sisou commented Oct 4, 2021

PR for change-set viewing purposes. Since this code is already deployed on both test- and mainnet, this PR will be merged when tests are green.

This way, it can be displayed over the CheckoutManualPaymentDetails
too without the need to flip the card.
Also refactor checkout card names and the instantiation of cards in the
carousel. Also includes some improvements to the Checkout demo.
- style of link to manual payment options for isPointOfSale case
- adaption of size and position of QR code in isPointOfSale case
- improve style of manual payment screen for more than 3 entries
- improve hover and focus style of secondary links
- let unselected card placeholder entirely cover long translations
  of page title
- fix of timer theme
For non point of salce checkouts prefer recently used currencies,
for point of sale prefer Bitcoin and Ethereum.
Now it will be shown if the Checkout was not used for a month or
the disclaimer was last displayed one year ago.
- internationalize some missing strings
- change title to "Crypto-Checkout powered by Nimiq"
- make BTC the default unit in the manual payment screen instead
  of mBTC
@sisou sisou merged commit f9d0d8b into master Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants