USDC-on-Polygon integration #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODOs: - Copying ethers.js into dist folder and replacing script path
Reason is that ethers.BigNumber cannot represent decimals, only integers.
Converted with browserify. Use as `new OpenGSN.TypedRequestData()`
Instead of a Polygon transaction. Misses parsing of RelayRequest, is currently trusting the input.
Remove identicon selection, instead focus more on explaining Login Files.
Also migrate transifex config to new client.
[skip ci]
…pproval only iff they are needed
Update typescript such that projects can add the Keyguard client via gitpkg without it failing to build if they include other dependencies which use newer typescript syntax, which somehow affect the client build. Also setting the tsconfig.json target to es2021 as our rollup version is not compatible with the current esnext yet.
To better reflect that this balance relates to the USDC token, not Polygon's native currency.
To reflect that no LoginFile selection is happening anymore.
…address is still the sender
danimoh
added a commit
that referenced
this pull request
Nov 12, 2023
The Overlay component is not used in the create flow or anywhere else anymore since USDC support was merged (PR #465), and is incompatible with the changes in the iOS pointer-events bug fix (PR #470), where pointer-events were enabled on the overlay-frame when they shouldn't. The incompatibility does not show directly anymore since PR #465 was merged, but showed on the master branch before PR #465 that PR #470 was originally targeting.
sisou
added a commit
that referenced
this pull request
Nov 26, 2023
Thanks @danimoh for finding it: #465 (comment)
sisou
added a commit
that referenced
this pull request
Nov 26, 2023
Thanks @danimoh for finding it: #465 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate Polygon address(es) when creating a new account or logging in, and add request to sign OpenGSN relay requests for transferring USDC via Nimiq's USDC-transfer-contract. Also add USDC support to sign-swap request(s).