Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overviewer Support #17

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Overviewer Support #17

wants to merge 14 commits into from

Conversation

Zeromusta
Copy link

Hi.

I have added Overviewer support to your docker image. Happy for you to reject this pull if you want to keep your docker image clean and simple, also happy for you to critique the way I did things and reject it for that (most of it could be done a lot better!).

I originally forked and played with your repo to learn about using docker, and was going to keep my hacked changes to myself. I wrote them quickly just to get things going, but later realised this kind of thing may be appreciated by others.

If you have better ways of doing things or want me to change anything, don't hesitate to ask. Also, don't feel obliged to take any of this on, only if you're interested :)

Thanks! Love your work.

Cheers,
Mark.

@nimmis
Copy link
Owner

nimmis commented Jan 11, 2017

I will check you pull as I have been thinking of adding overviewer myself.

If It's implemented it will be as a separate tag <i.e overviewer> to allow people to choose if there is interested to add the functionality as it will add more memory and cpu.

If I add it you will be credited for it

@Zeromusta
Copy link
Author

Good idea on the new tag. I'll leave it with you, enjoy!

@BirkhoffLee
Copy link
Contributor

BirkhoffLee commented May 27, 2017

Docker containers are meant to be running only ONE service per container. You should not do that as it will break maintainability, flexibility and make stuff go more complex. Something you should do is to use multiple containers and link them together. Docker Compose is a good thing to try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants