Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #225

Merged
merged 22 commits into from
Apr 10, 2023
Merged

Fixes #225

merged 22 commits into from
Apr 10, 2023

Conversation

SunsetTechuila
Copy link
Contributor

@SunsetTechuila SunsetTechuila commented Apr 6, 2023

for some issues mentioned in #220 and more

@SunsetTechuila
Copy link
Contributor Author

now fix #219 too

@SunsetTechuila
Copy link
Contributor Author

and partially #223

@SunsetTechuila
Copy link
Contributor Author

SunsetTechuila commented Apr 8, 2023

fix animation lags

@SunsetTechuila
Copy link
Contributor Author

SunsetTechuila commented Apr 8, 2023

#222 too
also now it has exactly the same animation as in WinUI 3 and almost the same size
and it applies to all sliders automatically - in the settings for example (there was no dot before)

@SunsetTechuila
Copy link
Contributor Author

  • before:

image

  • after:

image

@SunsetTechuila
Copy link
Contributor Author

SunsetTechuila commented Apr 8, 2023

image
this thing
was removed in that commit by mistake (at least I think so)

@SunsetTechuila
Copy link
Contributor Author

SunsetTechuila commented Apr 9, 2023

match and notmatch operators behave differently when used with arrays - they do not return true/false, they return strings matching the condition.
-notmatch "xpui.js_find_8008" will return all strings not containing "xpui.js_find_8008", so the condition ($configFile -notmatch "xpui.js_find_8008") will always be true

@SunsetTechuila
Copy link
Contributor Author

  • before:

image

  • after:

image

@SunsetTechuila
Copy link
Contributor Author

  • before:

image

  • after:

image

@SunsetTechuila
Copy link
Contributor Author

  • before:

image

  • after:

image

@SunsetTechuila
Copy link
Contributor Author

image

@SunsetTechuila
Copy link
Contributor Author

SunsetTechuila commented Apr 9, 2023

it was difficult, but now it seems to work with all languages
#219

@nimsandu nimsandu merged commit 4fca3ab into nimsandu:main Apr 10, 2023
@nimsandu
Copy link
Owner

@SunsetTechuila its huge!
thanks a lot!

@SunsetTechuila SunsetTechuila added the bug fix Fix something isn't working label Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Fix something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants