Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name change proposal #33

Closed
zedeus opened this issue Jan 11, 2019 · 8 comments
Closed

Name change proposal #33

zedeus opened this issue Jan 11, 2019 · 8 comments
Labels

Comments

@zedeus
Copy link

zedeus commented Jan 11, 2019

toast clashes with an ffmpeg dependency for GSM compression, so machines with an improperly setup path would cause nimterop to fail with a strange error message complaining about invalid arguments.

Maybe c2ast would be a fitting name? If nimterop plans to support more languages than C/C++ that would be inaccurate though. astgen or genast perhaps? ast2nim?

@genotrance
Copy link
Collaborator

Most of these might exist already - I think we might be better off going with nimterop itself since it is a quite unique name.

Open to feedback though.

@timotheecour
Copy link
Contributor

anything starting with nim would be fine, eg toast => nimteropast (makes it clear it's related to nimterop)

@genotrance
Copy link
Collaborator

Really speaking, it is taking in an AST and generating Nim so it isn't to ast anymore.

Here's some other options:

  • ast2nim
    -asterop
  • nimtercli
  • astercli

I can't call it nimterop since it will clash with the folder.

@timotheecour
Copy link
Contributor

not smthg ud type everyday so maybe nimteropcli

@genotrance
Copy link
Collaborator

Once toast is a relative path from cimport, this won't be needed anymore. We can keep the name toast.

@genotrance
Copy link
Collaborator

Toast is now a relative path for cimport so that won't fail. If user wants to use on command line and it clashes, he can now give full path. I don't think we need to rename anymore. Please close if you agree.

@zedeus
Copy link
Author

zedeus commented Feb 1, 2019

Fine with me.

@zedeus zedeus closed this as completed Feb 1, 2019
@timotheecour
Copy link
Contributor

timotheecour commented Feb 1, 2019

on the other hand it's probably not too hard to fix assuming we can rename the generated binary, see #70 (comment) for an approach; tracking inhttps://github.com/nimterop/wrappers/issues/18 for a related issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants