-
Notifications
You must be signed in to change notification settings - Fork 39
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix #62 ; toast is now automatically built on demand
- Loading branch information
1 parent
f367234
commit fc2620d
Showing
2 changed files
with
30 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -162,3 +162,4 @@ when isMainModule: | |
"debug": 'd', | ||
"pgrammar": 'g' | ||
}) | ||
|
fc2620d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick thoughts - I like that we have a fixed path but why not just point to toast in
currentSourcePath.parentDir
and call it? If it's not there, complain. Why rebuild and put it in temp? This will skip recompile for standard users as well as elaborate toast dep check every time anyone compiles any wrapper. Toast won't change for them so it will be a waste of build time.Meanwhile, you'd want nimble to build binaries on
nimble develop
rather than doing it here.With full path, we can also close #33 since there will be no collisions.
This really is only a problem for nimterop devs like us, better to rebuild toast in the
nimble test
target in the nimble file.