-
-
Notifications
You must be signed in to change notification settings - Fork 814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bad default location for REPORTS_ROOT #54
Comments
You're right, I agree that IMO the nice way would be to have two separate ConfigMaps, one for reports and one for configuration. And when the one for configuration is mapped to So the main configuration might have to be moved to somewhere else, e.g. Or am I over-complicating matters and it's fine to have one ConfigMap for config and reports? I'd love to hear your opinion on this, and @tobiasge's as well, as he initially suggested to move the configuration to |
Hello, at the moment we're not using reports but I also think I won't be able to implement this now because I'm on holiday for the next weeks. If this can wait I will do the implementation. @flipkill1985 Could you test this in our deployment? |
@tobiasge Have you had the chance to look into this? Would one ConfigMap for config and reports be fine or do you think they should better be separated? |
Hello, |
Current Behavior
Due to the way your current implementation references configuration files located in
/etc/netbox/
instead of/opt/netbox/netbox/netbox/
, when you browse tohttp://localhost/extras/reports/
, the following is seen:Yes, I know this can be changed in the
netbox.env
by setting a value forREPORTS_ROOT
, however, in my opinion, this "default" is not a good idea. I don't believe anyone is going to use the/etc/reports
location to store custom python scripts specific to NetBox.I'd like to propose using
/etc/netbox/reports/
as an alternative, but I didn't want to go through the hassle of creating a PR if it wasn't going to be merged.What are your thoughts one way or the other?
Expected Behavior
N/A
Debug Information
N/A
The text was updated successfully, but these errors were encountered: