Websocket example start script crashes when volume name contains space

[luisgerhorst]

I was trying to make the example for web sockets run on my Mac and the start script ./_rel/bin/websocket_example crashed because I have a space in my volume name.

$ ./_rel/bin/websocket_example console
egrep: /Volumes/Macintosh: Is a directory
egrep: SSD/Users/luis/Documents/erlang/cowboy/examples/websocket/_rel/releases/1/vm.args: No such file or directory

Replacing the space in Macintosh SSD by an underscore fixed the problem.

[tsloughter]

Could you post what these lines from your _rel/bin/websocket_example file?

# Use $CWD/vm.args if exists, otherwise releases/APP_VSN/vm.args, or else etc/vm.args
if [ -e \"$RELEASE_ROOT_DIR/vm.args\" ]; then
    VMARGS_PATH=$RELEASE_ROOT_DIR/vm.args
    USE_DIR=$RELEASE_ROOT_DIR
else
    USE_DIR=$REL_DIR
    if [ -e \"$REL_DIR/vm.args\" ]; then
        VMARGS_PATH=\"$REL_DIR/vm.args\"
    else
        VMARGS_PATH=\"$REL_DIR/vm.args\"
    fi
fi

I'm updating it to quote the first one as well, but your path should mean it goes into the else and is thus already quoted. But maybe you have an older version of relx.

[essen]

relx is automatically downloaded by erlang.mk now.

[luisgerhorst]

At me it looks like this. I'm not sure what version of relx I have.

# Use $CWD/vm.args if exists, otherwise releases/APP_VSN/vm.args, or else etc/vm.args
if [ -e "$RELEASE_ROOT_DIR/vm.args" ]; then
    VMARGS_PATH=$RELEASE_ROOT_DIR/vm.args
    USE_DIR=$RELEASE_ROOT_DIR
else
    USE_DIR=$REL_DIR
    if [ -e "$REL_DIR/vm.args" ]; then
        VMARGS_PATH="$REL_DIR/vm.args"
    else
        VMARGS_PATH="$REL_DIR/vm.args"
    fi
fi

[essen]

Does it still happen with Cowboy master?

[essen]

I will assume this is fixed as upstream reports it should work. If you can confirm though I'll be thankful. If it doesn't work please reopen the ticket. Thanks!