Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-patching rebar project fails when version string starts with ">=" #938

Closed
lukebakken opened this issue Nov 3, 2021 · 4 comments
Closed

Comments

@lukebakken
Copy link
Contributor

To demonstrate, clone https://github.com/lukebakken/gt-eq-dep-version and run make. When gen_smtp is auto-patched, this configuration in deps/gen_smtp/rebar.config trips up erlang.mk:

{deps, [{ranch, ">= 1.8.0"},
        {hut, "1.3.0"}]}.

...because it is turned into this in the generated Makefile

DEPS += ranch
dep_ranch = hex >= 1.8.0 ranch

I believe I need to expand the semver strings parsed by this code.

Found while working on gotthardp/rabbitmq-email#45

@essen
Copy link
Member

essen commented Nov 4, 2021

Yes it just hasn't been implemented. You can add an autopatch-gen_smtp:: target after include erlang.mk to correct this after autopatch has run.

@lukebakken
Copy link
Contributor Author

Thanks @essen. If you haven't yet started on supporting additional semver strings let me know, I could spend some time on that.

@essen
Copy link
Member

essen commented Nov 4, 2021

I have nothing in progress but there is probably some hacky support in the autopatch code.

@essen
Copy link
Member

essen commented May 12, 2023

This should be done now.

@essen essen closed this as completed May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants