Enabling plugin support with later version of erl/23 #45
Comments
|
Compile i'm getting so close I can taste it: |
|
I'll try to get some time this week for this issue. |
|
cool thankyou. ive been able to get through most of the make file, however its failing on these install-cli-script portions for rabbitmq-server / rabbitmq in deps. when i remove these as dependencies on the respective make files and attempt to make dist on the top leve rabbitmq-email plugin, im getting an error on an erlang behavior context I have been able to successfully build gen_smtp 0.15.0 with rebar3 and erl21, and that works to some extent with the precompiled rabbit-email-0.40.0.ez plugin, up to the point of a rabbitmq-server restart. at that point the plugin is unable to load due to the broker not being able to start, so I think it's definitely an erl21 - 23 compatibility issue. I believe you guys have a call with us coming up to discuss some project work on this. Ultimately we need to compile against erl23 and will need compilation support moving forward to keep current with our vuln remediation work for rabbitmq-server. at the moment, we have a way to work around this with rabbit/otp 3.8.3/21.3.x, but id rather do this correctly then trying to obfuscate stuff. |
|
but clearly, we want to make sure this is an equitable situation for everyone involved. and i apologize for reaching out to you directly on slack. just wanted to open lines of comms on this. so i think this might be scoping out a support contract or something like that. i dont think im on the call, but my colleagues should be able to give some details. if needed i can jump on and give more detailed information. |
|
i wonder if it might make sense to pull the 0.15.0 branch for gen_smtp and try to compile that as the dependency with erl23 |
|
Here is where I am now. NOTE: I am using Erlang 23.3.4.8
At this point it seems like https://github.com/gotthardp/rabbitmq-email isn't compatible with the latest |
|
It appears that Now when I start RabbitMQ, this is the error: This is due to this plugin not being compatible with RabbitMQ's boot sequence. I'll continue working on it! |
|
yeah, heres an interesting part to this one. if you disable the plugin, then start the broker, then enable the plugin it'll work so its the initial gen_server.erl compatability issue. thankyou btw for looking at this |
Great, that confirms that this plugin is not compatible with the current RabbitMQ boot sequence. |
|
@mforde84 I'm finding a couple issues while updating this plugin and |
Found when working on gotthardp/rabbitmq-email#45
|
thanks @lukebakken, just spoke with our leads and the intro call with vmware went well. we are regrouping next week to discuss internally with some people on our dev side of house. |
|
@mforde84 I've been busy with customer support but can return to this today. I've made good progress and am now just getting the test suite to work. |
|
Great thats awesome. Thankyou for circling back. I believe we are
discussing with the team about support contract today. So I'll likely have
more to report back there soon.
Thanks again, it's much appreciated.
…On November 11, 2021 11:00:26 AM Luke Bakken ***@***.***> wrote:
@mforde84 I've been busy with customer support but can return to this
today. I've made good progress and am now just getting the test suite to work.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
|
|
@mforde84 I have this plugin updated and working with the latest Question for you - currently We do have a fork of If you have a second, would you mind cloning and building the |
|
I'm still seeing build errors. And it seems to be the same install-cli-scripts issues ```make[1]: Leaving directory |
|
not sure if its because I'm building off rabbitmq-server tag v3.8.9 . Not to be an imposition but do you have a play by play on this build, because I think I'm recovering old ground and I'm not sure my build process was valid in the first place. thanks. |
|
let me investigate the eiconv dependancies, I assume that I can compile against whatever lib version my base cent7 system has? |
|
or it looks like a separate plugin, let me see if i can compile that real quick |
|
So the eiconv git you linked compiles successfully under my current installations: however it doesn't generate the typical .ez package. is there a make option or something similar to repackage? |
It doesn't do that out of the box, unfortunately. An Then, run the following command: You should see output similar to the following: I am working on the "best way" to put all of this together since, as you can see, it's not obvious! Prior to my work our fork of |
|
@mforde84 I have finalized installation instructions here: https://github.com/gotthardp/rabbitmq-email/tree/update-for-rmq#installation Let me know how that works in your environment. Note that ONE MORE THING: these updates require the next releases of RabbitMQ that have this PR in them. I'm going to see if I can work around that. |
|
Dude you're awesome 👌. Sorry got sidetracked today. I'm going to run
through the upgrade tomorrow. Thankyou again.
…On November 15, 2021 2:45:59 PM Luke Bakken ***@***.***> wrote:
@mforde84 I have finalized installation instructions here:
https://github.com/gotthardp/rabbitmq-email/tree/update-for-rmq#installation
Let me know how that works in your environment.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
|
|
hey ran into a compile issue |
|
i was able to compile yesterday, maybe it was the addition of eiconv hmm |
|
let me check |
|
Please start with a fresh clone and use the instructions to which I linked here. Do NOT paste large amounts of text into a comment! Save all output into a file and attach the file. |
|
Sorry, but yea followed the steps that were linked, and ended up with this error. This is a fresh clone as well. I'll try again. |
|
Im getting the same error. I tried building off both the master and the branch. |
|
The Without seeing what you tried and the output, I can't help. Save all the commands you run and their output into a file, and attach the file to your next comment. |
|
Sorry for all the back and forth. I'll get that to you momentarily. |
You have something amiss with your Erlang installation because it appears that Common Test is not available. What OS are you using and how, exactly, is Erlang being installed? |
|
10.128.3.228 :: root -> cat /etc/redhat-release library support is installed through package cloud I assume I dont have appropriate devels with those packages |
|
Im going to attempt to install erl/otp from source and try building off of that |
|
OK. You could also just use a full Erlang package, like from ESL (Erlang Solutions). |
|
Great took your advice with the ESL packaging. Seems to have worked well.
I'm going to do they upgrade tomorrow and confirm everything looks good.
Thankyou again. I assume this ticket is clear to close. If i run into any
issues, I can just reopen.
Martin
…On Tue, Nov 16, 2021 at 2:28 PM Luke Bakken ***@***.***> wrote:
OK. You could also just use a full Erlang package, like from ESL (Erlang
Solutions).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#45 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE7QUTRCVI3NHCHWBB6TFHLUMKWGLANCNFSM5GYQXU6Q>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
Hey Luke, So after some initial testing is looks like the plugin is blocking the rabbitmq-server boot sequence. It enables with an active service, but on service restart or cold start, the plugin is causing a crash. boot_sequence_fail.txt Sorry the dump file is quiet large so I'm not entirely sure where to look for issues but generally it appears to be with: |
|
im going to retry compiling |
|
I need the full RabbitMQ log file. Re-compiling probably won't change anything. |
|
More than likely you're hitting the issue fixed here: I will know when I get the full RabbitMQ log. If that's the case, you will have to wait for the next RabbitMQ release if I can't figure out a workaround. |
|
Let me turn on more verbose logging as well. Could this be related to compiling against esl-erlang, and but running the rabbitmq-server with the packagecloud rpm? Maybe some missing library support dependancies between those. |
|
Yes, you are hitting the issue to which I linked: Let me see what I can do. |
|
cool, will do |
|
alright, looks good. confirmed server v3.8.9 / erlang v23.2.1 successfully boots with the plugin many thankyous martin |
|
Ok thankyou
…On November 22, 2021 3:28:30 PM Luke Bakken ***@***.***> wrote:
@mforde84 I am wrapping up PR #46. Please note that I have only tested the
changes using RabbitMQ v3.9.x versions. I suggest upgrading ASAP!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
|
|
I'll schedule our upgrade
…On November 22, 2021 3:28:30 PM Luke Bakken ***@***.***> wrote:
@mforde84 I am wrapping up PR #46. Please note that I have only tested the
changes using RabbitMQ v3.9.x versions. I suggest upgrading ASAP!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
|
I've been trying to get rabbitmq-email to run on our rabbit stack, and am running into some issue.
Currently we are running:
rabbitmq-server 3.8.9
erl/otp - 23 - Erlang/OTP 23 [erts-11.1.5] [source] [64-bit] [smp:2:2] [ds:2:2:10] [async-threads:1] [hipe]
First thing I tried was moving the precompiled ez package to the plugins directory for rabbitmq-server
The service hangs and returns a dependancy error on gen_smtp
So I build gen_smtp from git
The resulting build is as follows:
So what I had assumed here was that the library support was important for gen_smtp server functionality so I copied the following build directories to the erland library path:
Now when I restart rabbitmq-server it successfully compeltes and offers the plugin for activation
Next I update the advanced rabbit config to include the sample server config listed in the git
Service restarts appropriately with the new configs, however when I go to enable the plugin it appears that rabbitmq-email plugin can not start the gen_smtp server
However when I attempt to start the gen_smtp server from a erl shell it successfully completes:
This is also successful from the /bin/erl
My current thinking is that there is a erl/otp compatibality issue between the plugin that was compiled with otp/21 and the gen_smtp libraries that are compiled against otp/23
So currently, I'm working on trying to compile the rabbitmq-email plugin with otp/23, and am running into some issues with build. But before I get into that, I think next steps I will be taking is trying to downgrade, erl/otp to 21 and trying to start the precompiled plugin. Until I can test, I'd like to ask if you have any suggestions or recommendation on anything I've currently outlined.
The text was updated successfully, but these errors were encountered: