Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build automatically project PLT for make dialyze #37

Closed
wants to merge 5 commits into from
Closed

build automatically project PLT for make dialyze #37

wants to merge 5 commits into from

Conversation

andrzejsliwa
Copy link
Contributor

the goals:

  • build automatically project PLT when file is missing on make dialyze
  • don't needs to build it explicitly (by default file is updated automatically by dialyzer when this is needed)

@essen
Copy link
Member

essen commented Jan 20, 2014

I'll get back to you after merging #40 which does a better job at defining the plt variable. Thanks.

@essen
Copy link
Member

essen commented Feb 20, 2014

#40 has been merged, please update your PR for merging!

Also I don't think you need an "if/else", you can make build-plt depend on the file and add a rule for the file itself I think.

@andrzejsliwa
Copy link
Contributor Author

@essen done.

@andrzejsliwa
Copy link
Contributor Author

hmm. I need to switch back to if.. because target is not working like if... its always building even if file exist.

@essen
Copy link
Member

essen commented Feb 22, 2014

You probably need to escape the dot.

Loïc Hoguin
http://ninenines.eu

-------- Original Message --------
From:Andrzej Sliwa notifications@github.com
Sent:Sat, 22 Feb 2014 14:47:08 +0100
To:"extend/erlang.mk" erlang.mk@noreply.github.com
Cc:Loïc Hoguin essen@ninenines.eu
Subject:Re: [erlang.mk] build automatically project PLT for make dialyze (#37)

hmm. I need to switch back to if.. because target is not working like if... its always building even if file exist.


Reply to this email directly or view it on GitHub.

@andrzejsliwa
Copy link
Contributor Author

fixing...

@essen
Copy link
Member

essen commented Jul 20, 2014

Looks good. Please do the equivalent change to plugins/dialyzer.mk and then squash all in one commit, thanks!

@essen
Copy link
Member

essen commented Jul 25, 2014

Hello!

@andrzejsliwa
Copy link
Contributor Author

fixed in #99

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants