Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add callbacks on starting, start failure and stopping of supervisors #118

Closed
essen opened this issue Aug 12, 2015 · 4 comments
Closed

Add callbacks on starting, start failure and stopping of supervisors #118

essen opened this issue Aug 12, 2015 · 4 comments

Comments

@essen
Copy link
Member

essen commented Aug 12, 2015

This would most likely be better for Ranch 2 in #111 as we will have a separate process to better manage the listening socket anyway.

Also related to rabbitmq/rabbitmq-server#260.

@essen essen changed the title Add callbacks on starting and stopping of supervisors Add callbacks on starting, start failure and stopping of supervisors Aug 13, 2015
@essen essen added this to the 2.0.0 milestone Aug 13, 2015
@essen
Copy link
Member Author

essen commented Nov 24, 2015

Another callback that would be useful is one that allows acting on a socket immediately after accept. One could for example do this kind of operation: http://erlang.org/pipermail/erlang-questions/2014-April/078776.html

@essen
Copy link
Member Author

essen commented Nov 24, 2015

Actually would be good if we had a callback for before accept and a callback after accept (and before starting the process).

@essen
Copy link
Member Author

essen commented Jul 5, 2018

As far as I can tell these will no longer be necessary in Ranch 2.0 since we will get the socket from ranch:handshake and can act on it immediately.

@essen essen closed this as completed Jul 5, 2018
@essen
Copy link
Member Author

essen commented Jul 5, 2018

And the starting/start failure/stopping can be done without a callback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant