Upstream sni #169
Closed
Upstream sni #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also included the other new options from that release
|
Something is funky in the diff. The sni options are already there (with a less precise type I suppose) and yet the diff acts like they are not. Please remove the merge commit and/or rebase. Also the backlog and send options are TCP options. See https://github.com/heroku/ranch/blob/f4d23d7128e89efcce323df3ef1979bfa1e8e917/src/ranch_ssl.erl#L83 |
|
UH alright. I'll double check that and re-open later. |
|
Yeah you're right, just something that really went weird in there. |
|
Yeah... git is not supposed to do this. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding some annotations for 18.0+ options that were added to the SSL libs.