Allow new ssl option certs_keys in ranch_ssl #343
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Couldn't we just use |
|
There's a few that we don't allow. |
|
In |
|
There's a few here: https://github.com/ninenines/ranch/blob/master/src/ranch_ssl.erl#L146 |
|
I've pushed commits that fix the tests. |
Maria-12648430
force-pushed
the
add_otp25_ssl_opts
branch
from
4c6bc03
to
f4093d6
Compare
|
Ok, rebased and re-pushed :) Do you want dedicated tests for this certs_keys case? Because all the cert stuff in the tests is done via |
|
That should be fine without adding tests. Thanks. |
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #342.
The ssl_opts are a drag... 馃檮
No tests, it looks like many ssl tests are broken for OTP 25 anyway鈽癸笍