Skip to content

Commit

Permalink
Avoid shell quoting issues in build system
Browse files Browse the repository at this point in the history
Double quotes may have different meaning on different systems. Avoid that trap
by running the perl binary directly instead of through some shell.

Should fix GH #1728
  • Loading branch information
niner committed Apr 13, 2018
1 parent 137028f commit 8e080d0
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions Build.pm
Expand Up @@ -3,10 +3,10 @@ use LibraryMake;

class Build {
method build($dir) {
shell('perl -e "use v5.18;"')
run('perl', '-e', 'use v5.18;')
or die "\nPerl 5 version requirement not met\n";

shell('perl -MFilter::Simple -e ""')
run('perl', '-MFilter::Simple', '-e', '')
or die "\nPlease install the Filter::Simple Perl 5 module!\n";

my %vars = get-vars($dir);
Expand Down
4 changes: 2 additions & 2 deletions configure.pl6
Expand Up @@ -8,10 +8,10 @@ sub MAIN(:$test, :$install is copy) {
}

sub configure() {
shell('perl -e "use v5.18;"')
run('perl', '-e', 'use v5.18;')
or die "\nPerl 5 version requirement not met\n";

shell('perl -MFilter::Simple -e ""')
run('perl', '-MFilter::Simple', '-e', '')
or die "\nPlease install the Filter::Simple Perl 5 module!\n";

my %vars;
Expand Down

0 comments on commit 8e080d0

Please sign in to comment.