Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple descriptions #1

Closed
ninest opened this issue Jul 23, 2022 · 2 comments
Closed

Multiple descriptions #1

ninest opened this issue Jul 23, 2022 · 2 comments
Assignees

Comments

@ninest
Copy link
Owner

ninest commented Jul 23, 2022

Some courses like CS 2500 or CS2510 have sections (accelerated) with different descriptions

@ninest ninest self-assigned this Jul 23, 2022
@ninest
Copy link
Owner Author

ninest commented Jul 23, 2022

The description for accelerated fundies isn't that helpful and fetching so many (of the same) descriptions for a course takes too long.

The way I'm handling it currently is

  • fetch description for first section (and save to description list)
  • for each section, fetch description
    • if that description is in the description list, assume that all courses have the same description
      • save that description and break out of the loop
    • else, save the description in the description list

The issue is that if there are more than one accelerated sections which have the same description

@ninest
Copy link
Owner Author

ninest commented Jul 23, 2022

I'm no keeping a list COURSES_WITH_ALT_SECTIONS (need a better name!) that contains courses that may contain sections with different sections.

Fetching descriptions is too slow without this

// Courses with sections that may contains different descriptions 
// (Fundies vs Accelerated Fundies)
export const COURSES_WITH_ALT_SECTIONS = [
  { code: "CS", number: "2500" },
  { code: "CS", number: "2510" },
];

ninest added a commit that referenced this issue Jul 23, 2022
@ninest ninest closed this as completed Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant