Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close() not working correctly with input, output streams #11

Closed
cowtowncoder opened this issue Sep 28, 2011 · 1 comment
Closed

Close() not working correctly with input, output streams #11

cowtowncoder opened this issue Sep 28, 2011 · 1 comment

Comments

@cowtowncoder
Copy link
Contributor

As Dain S pointed out, currently Input-/OutputStream deal with close() in a way that is both incompatible with default JDK behavior, and potentially wrong wrt buffer recycling. The thing is that JDK actually expects an IOException to be thrown, when read/write is done on closed stream; and although there may deviations (I think System.out/err do not do this for example; nor StringWriter), I think we should throw an exception (and at most allow exception throwing be disabled as and option).
cowtowncoder pushed a commit that referenced this issue Sep 29, 2011
Completed fix for #11, throwing IOException after input/output stream…
41ea34f 
… closed, read/write attempted
@cowtowncoder
Copy link
Contributor Author

Fixed in 0.8.6 (just released)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cowtowncoder