Overload of factory methods and constructors in Encoders and Streams, to... #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to allow specifying a concrete BufferRecycler instance, as an alternative to the default ThreadLocal soft-references policy. The change does not break compatibility with existing API, but adds flexibility for resource-eficiency if used from pools (different threads could reuse the same BufferRecycler instances, avoiding the creation of instances on a per Thread basis) and some minor performance gain in preexistent LZFOutputStream constructors (because ThreadLocal is only accessed once).
|
Makes sense, looks good to me. Thank you for this contribution; I'll merge it in a minute. |
cowtowncoder
added a commit
that referenced
this pull request
Jul 14, 2014
Overload of factory methods and constructors in Encoders and Streams, to...
cowtowncoder
added a commit
that referenced
this pull request
Jul 14, 2014
|
Thank to you for this great library! -----Original Message----- Makes sense, looks good to me. Thank you for this contribution; I'll merge it in a minute. Reply to this email directly or view it on GitHub: |
|
@serverperformance Thank you once again for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... allow specifying a concrete BufferRecycler instance, as an alternative to the default ThreadLocal soft-references policy.
The change does not break compatibility with existing API, but adds flexibility for resource-eficiency if used from pools (different threads could reuse the same BufferRecycler instances, avoiding the creation of instances on a per Thread basis) and some minor performance gain in preexistent LZFOutputStream constructors (because ThreadLocal is only accessed once).