Bug in test of shared modules.

[karpierz]

• OS Platform, Distribution, and Version: All
• Python Distribution and Version: 3.6
• Java Distribution and Version: Oracle Java 1.8
• Jep Version: 3.8.2

Bug in test of shared modules.

Trivial patch:

--- src\test\python\test_shared_modules.py.org	2018-08-10 19:19:42.000000000 +0200
+++ src\test\python\test_shared_modules.py	2018-08-16 11:58:07.691470600 +0200
@@ -25,9 +25,9 @@
 
     def test_unshared(self):
         # The default jep has no shared modules so it should not be possible
-        # to access topInterpreterModules
+        # to access mainInterpreterModules
         with self.assertRaises(AttributeError):
-            jep.topInterpreterModules
+            jep.mainInterpreterModules
     
     def test_shared_argv(self):
         jep_pipe(build_java_process_cmd('jep.test.TestSharedArgv'))

Thanks,
Adam Karpierz

[ndjensen]

Thanks. These appear to be code review comments, not actual issues. Which thankfully means our code must be fairly readable. If there's another release of Jep 3.8 (dependent on what issues are reported), we'll probably include this on the next Jep 3.8 release, otherwise it will go into Jep 3.9.

[karpierz]

::> These appear to be code review comments
Hm.. Rather it is a test bug.
'topInterpreterModules' has been recently renamed to 'mainInterpreterModules' in whole jep code.
Only exception is just a test above.
With this bug the test will be passed regardless the default jep has or has no shared modules
but should be failed when the default jep has shared modules (in case of error in code in the future
or something...).

[ndjensen]

Good point.

[bsteffensmeier]

Fix is in dev_3.9 with d835aad