Enable isinstance to work with PyJClass. #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 7, 2022
ndjensen
approved these changes
Nov 14, 2022
|
This is great. To work around this limitation with the currently released version of Jep, I was doing |
|
This will be included in the 4.1.1 release which I am planning to put out around the end of December. |
|
I forgot to mention, I think you should add an entry in the 4.1 release notes that points out isinstance now works as one might expect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #438
I'm not sure if this will go in 4.1.1 or 4.2, since we haven't created a dev_4.2 branch yet I am currently targeting dev_4.1 but I may wait to merge this until we decide on a release plan.