New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
configure.py/bootstrap.py uses CXX with CFLAGS #673
Comments
ninja has no .c files. Is this really a problem? |
Well, yes (IMHO). It doesn't particularly matter whether the project has .c or .cxx or .cpp or .cc files; it's that (by convention, I think? I actually can't seem to find any real citations or standards for this) typically flags for the C compiler are put in CFLAGS and flags for the C++ compiler are put in CXXFLAGS. The example I use above is a simplified one for demonstration; by default, the values I typically have exported are Now, of course, I'm sometimes a quick fellow, picked up on what was happening and set my CFLAGS to my CXXFLAGS for this project, but (again, only my opinion) one shouldn't have to do that, I don't think. |
I'm closing the issue as I've opened #676 to address this. |
...rather than CXXFLAGS.
Thus,
CC=clang CXX=clang++ CFLAGS=-std=c11 CXXFLAGS=-std=c++11 configure.py; ninja
or the like raises
error: invalid argument '-std=c11' not allowed with 'C++/ObjC++'
.The text was updated successfully, but these errors were encountered: