Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior request for this: ninja-build#673
Prior attempted implementation: ninja-build#676
As with the prior implementation, this tries to ensure existing workflows that depend on using
CFLAGS
are not affected. SuppliedCFLAGS
andCXXFLAGS
are also now added toLDFLAGS
, since some C++ flags like-stdlib
are needed by the linker too.