Support for AIX #1007
Support for AIX #1007
Conversation
/bin/od on Solaris and AIX both generate tabs.
On AIX, inttypes.h gets indirectly included by build_log.h. It's easiest just to ask for the printf format macros right away.
AIX supplies getopt but not getopt_long. We can't use the embedded getopt implementation, since the constness of its arguments doesn't match the AIX system routine.
| @@ -12,6 +12,14 @@ | |||
| // See the License for the specific language governing permissions and | |||
| // limitations under the License. | |||
|
|
|||
| // On AIX, inttypes.h gets indirectly included by build_log.h. | |||
| // It's easiest just to ask for the printf format macros right away. | |||
| #ifndef _WIN32 | |||
There was a problem hiding this comment.
Should this check for _WIN32 or _MSC_VER? Would MinGW want the __STDC_FORMAT_MACROS define?
There was a problem hiding this comment.
I simply moved the #define up from lower down the file. It was previously guarded by #ifndef _WIN32.
|
Can you investigate a bit why the segfault happens? |
|
Sorry for the lack of response here. I investigated the "segfault" a bit more, and it turns out that that was a bad description. In our AIX environment, I see different behaviors depending on the filesystem where the executable file runs. On NFS, I get |
|
Hi @nico and @martine, I'd appreciate if you could take another look here. I'm still pretty certain that most of these changes are good. Per my last comment in the unlink subthread, are you okay with that approach, and should I add an |
AIX does not support rebuilding ninja in-place from the bootstrapped ninja.
|
Force-pushed an update to the last commit to avoid the extra |
|
Thanks for sticking with us, very sorry about the delay, and thanks for tirelessly iterating on this. |
|
Thanks for merging! 😄 |
These changes add support for the AIX platform.
In our AIX 7 environment, the
SubprocessTest.InterruptChildtest does not pass due to the/bin/shshell being a really old version ofksh. I'll address the issue of using a different shell in a separate pull request.