Fix confusing smart console output from concurrent builds #1320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Developers tend to blame the last printed line when a build takes too long. Unfortunately, when building concurrently, the last printed line may have actually finished a long time ago. Under the current system, ninja does not update the status line to reflect what jobs are still running. This change makes ninja always print the longest running job instead. In other words, the likely build bottlenecks.
|
Hi @nico – Any chance you could please accept or reject this? Thanks! |
Closed
nico
added a commit
to nico/ninja
that referenced
this pull request
Apr 5, 2018
Developers tend to blame the last printed line when a build takes too long. Unfortunately, when building concurrently, the last printed line may have actually finished a long time ago. Under the current system, ninja does not update the status line to reflect what jobs are still running. This change makes ninja always print the oldest still running job instead. In other words, the likely build bottlenecks. Patch from David Zarzycki, originally uploaded at ninja-build#1320.
|
First, sorry about the long delay for getting around to this, I was away for a bit (cf https://groups.google.com/forum/#!topic/ninja-build/yUOLRh19M-w). Thanks for the patch, this seems like a really clean and clever solution to this problem. I merged it in #1405 (with attribution). |
|
Neat-o! Thanks! |
projectgus
pushed a commit
to projectgus/ninja
that referenced
this pull request
Apr 26, 2018
Developers tend to blame the last printed line when a build takes too long. Unfortunately, when building concurrently, the last printed line may have actually finished a long time ago. Under the current system, ninja does not update the status line to reflect what jobs are still running. This change makes ninja always print the oldest still running job instead. In other words, the likely build bottlenecks. Patch from David Zarzycki, originally uploaded at ninja-build#1320.
|
Hi! Due to #1418, I needed to revert this, sorry :/ Maybe we can think of a solution which avoids those two issues. For #1418 you can use To keep the performance it might be a good idea to wait a second or two, before updating the status line due to a finished edge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developers tend to blame the last printed line when a build takes too
long. Unfortunately, when building concurrently, the last printed line
may have actually finished a long time ago. Under the current system,
ninja does not update the status line to reflect what jobs are still
running. This change makes ninja always print the longest running job
instead. In other words, the likely build bottlenecks.