Add appveyor.yml for build & test on windows #1409
Conversation
|
Thanks! I think we used to have an appveyor config; I remember setting that up in the past. I think it used to be set up via a webhook, and there's still an appveyor webhook in https://github.com/ninja-build/ninja/settings/hooks (which you probably can't access). This stopped working when we moved the repo from evan's personal github to the ninja-build org. I was never able to figure out why – so I'm very . I think builds even get scheduled still, but they don't show up on pull requests (https://ci.appveyor.com/project/nico/ninja – whoops, looks like the build is currently broken, I must fix it). I'm pretty sure we never had an appveyor.yml – is that a new way to configure appveyor? Can I delete the webhook now? Do you know how my instance happens to know what to do? Do you know why my instance doesn't show up on pull requests? I'm happy to merge this, but I'd like to understand what's happening a bit more. But I can merge first and we can see if your instance shows up on pull requests first too. Let me know. |
I think that you need to do followings to enable appveyor in this project.
(Maybe you also need to tweak settings on https://ci.appveyor.com/project/ninja-build/ninja/settings) |
| image: Visual Studio 2017 | ||
| build_script: | ||
| - cmd: >- | ||
| call "C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Auxiliary\Build\vcvars64.bat" |
There was a problem hiding this comment.
Is there a way to test with multiple MSVS versions? The old bot used 2012 for example, and I think the cmake folks used to have a 2010 bot even.
There was a problem hiding this comment.
Thank you for merging!
appveyor supports vs2013, vs2015, vs2017, but not vs2012.
https://www.appveyor.com/docs/build-environment/#build-worker-images
If you want, I will make another PR.
|
Ok, 1 is done :-) I think 2 maybe isn't, there's only nico/ninja, not ninja-build/ninja as far as I know. |
|
I figured out where I had configured the build -- at https://ci.appveyor.com/project/nico/ninja/settings/build there's a "script" thingy where one can paste a script. Having this checked in to the ninja repo seems nicer though. |
|
[I don't remember whether I set up Appveyor for ninja before (maybe? I can't find the account that I might have used if I did), but when I did it for gyp I put all the config into the AppVeyor UI to avoid adding an appveyor file in the repo.] |
|
Oops, what you said. :) |
|
I had the bright idea to ask for help, at appveyor/ci#2237 Within minutes, the good appveyor people told me what button to push to make appveyor builds show up again. It looks like appveyor now uses appveyor.yml instead of the script I had configured in their web ui, which is probably a good thing :-) |
I'd like to ninja repository has build & test for windows.
This configuration build & test like below.
https://ci.appveyor.com/project/atetubou/ninja/build/1.0.3