Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NET Core support #18

Closed
maximtarasov opened this issue Jan 4, 2017 · 8 comments
Closed

NET Core support #18

maximtarasov opened this issue Jan 4, 2017 · 8 comments
Assignees
Labels

Comments

@maximtarasov
Copy link

@maximtarasov maximtarasov commented Jan 4, 2017

Hi!

Your project is very useful and it will be great, if you will introduce NET Core support.

@ninjanye
Copy link
Owner

@ninjanye ninjanye commented Jan 17, 2017

I completely agree. This is something I definitely want to do... Now that the holidays are over, I'll try and get this started

@ninjanye
Copy link
Owner

@ninjanye ninjanye commented Feb 28, 2017

Hi @maximtarasov

I begun to look at the work involved in adding .NET Core support and based on the current .Net Standard API (1.6) a fair amount of the code is unsupported and would need to be re-written. the good news is that all the code is supported in .NET Standard 2.0 so I think I may wait until that is released before adding this.

Sorry it is going to take longer than i had first hoped

@metamet
Copy link

@metamet metamet commented Mar 9, 2017

Anyone know of any alternatives for .NET Core?

I am in the middle of a migration, and trying to iron out all of the incompatibilities here... unfortunately, this is the only one that is in the way at this time.

@maximtarasov
Copy link
Author

@maximtarasov maximtarasov commented Mar 10, 2017

@ninjanye which components are unsupported on NET Core? Can you list them?

@ninjanye
Copy link
Owner

@ninjanye ninjanye commented Mar 13, 2017

@maximtarasov I'll dig out the report. From memory it was some reflection stuff and some linq bits. I'll double check. If the changes aren't to large, I'll update.

Sorry it's taken a while to get this sorted.

@ninjanye
Copy link
Owner

@ninjanye ninjanye commented Mar 20, 2017

@maximtarasov @metamet Good news, I have almost complete the port for .NET Core. I hope to get a new package out in the next few days. I'll keep you posted

@ninjanye ninjanye self-assigned this Mar 20, 2017
ninjanye added a commit that referenced this issue Apr 1, 2017
@ninjanye
Copy link
Owner

@ninjanye ninjanye commented Apr 2, 2017

@maximtarasov @metamet It took longer than anticipated but I have recently released an new version of Search extensions that is now entirely built on netstandard1.5

@ninjanye
Copy link
Owner

@ninjanye ninjanye commented Apr 5, 2017

Resolved as part of 38dbff1

Published to nuget (v2.1.0)

@ninjanye ninjanye closed this Apr 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.