Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specified Swift version in podspec #245

Merged
merged 1 commit into from Dec 12, 2018
Merged

Conversation

mplorentz
Copy link
Contributor

NVActivityIndicatorView will not build for me in Xcode 10.1 unless I manually change the Swift version in the pod settings. This PR fixes it by specifying the swift version in the podspec.

@ninjaprox ninjaprox merged commit b0174b7 into ninjaprox:master Dec 12, 2018
@mplorentz
Copy link
Contributor Author

@ninjaprox can you cut a new release so that I can start using this? Thanks!

@ninjaprox
Copy link
Owner

Thanks for the PR. This might solve #244 as well.
I'm not sure why when testing on my local, everything goes well, but some people get the build error regarding the Swift version.
4.4.1 is out 🚀.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants