Add async support #13
Conversation
Cargo.toml
Outdated
| rand_core = "0.6.3" | ||
| sha1 = "0.10.1" | ||
| smol = { version = "1.2.5", optional = true } | ||
| tokio = { version = "1.19.2", features = ["io-util"], optional = true } |
There was a problem hiding this comment.
At this point in time I do not wish to add tokio, smol, async-std and all their baggage to this codebase. I do plan on adding async support but I wanted to think about it properly before attempting it. I think the async streaming story in Rust is a tire fire and I don't want to add to it.
There was a problem hiding this comment.
ok, we should keep async feature then
There was a problem hiding this comment.
and then for each stream the user will need to provide their own compat implementation
There was a problem hiding this comment.
Yes I think that would be better
stevefan1999-personal
force-pushed
the
patch-async
branch
from
33859a4
to
8ab9ecf
Compare
since these two types are mimicking std extensions, it is better to denote them as compat
…each async example
stevefan1999-personal
force-pushed
the
patch-async
branch
from
209aa9c
to
09c4a8d
Compare
# Conflicts: # Cargo.toml
stevefan1999-personal
force-pushed
the
patch-async
branch
from
09c4a8d
to
67e484b
Compare
stevefan1999-personal
force-pushed
the
patch-async
branch
from
bb9842a
to
7dd2d31
Compare
|
hmm, speaking of the |
|
Any progress on this async support @ninjasource ? PS: This create is amazing, thanks a lot! Will hopefully test it out soon. |
|
Thanks @elpiel , I'll take a loot at async again. Been working on other stuff. |
|
I'm open in helping out with this effort as well. Can't wait to try out embedded websockets! |
|
embedded-hal and embedded-hal-async are now on version 1.0 🎉 |
No description provided.