-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency on WebActivator #5
Comments
I second this for a different reason. WebActivator appears to cause compatibility issues when targeting .NET4.0 from a .NET4.5 machine. It would be much better if we had a choice in this regard. Thank you. |
Ninject.Web.Common does not reference WebActivator. It is just the NuGet package that uses WebActivator as the default mechanism to integrate Ninject into your project. You have the option to remove this reference manually after the installation and delete the App_Start folder. |
This dependency also prevents |
Implemented in 872aa9f |
WebActivator is a nice addition to Microsoft.Web.Infrastructure but it's unsigned assembly. Ninject and Ninject.Web.Common are both signed.
Consider my scenario: I have a project with should be signed, I add Ninject's nuget packages, Ninject.Web.Common also installed WebActivator for me as its dependency. Then I try to build my singed distributive and get an error:
CSC : error CS1577: Assembly generation failed -- Referenced assembly 'WebActivator' does not have a strong name
Anyway WebActivator is only used in generated by nuget package code in App_Start. It would be nice to remove this too as it makes using of Ninject.Web.Common as a dependency for other packages hard.
The text was updated successfully, but these errors were encountered: