Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS X extension fix #22

Merged
merged 6 commits into from
Feb 15, 2014
Merged

OS X extension fix #22

merged 6 commits into from
Feb 15, 2014

Conversation

chrisjwu
Copy link
Collaborator

I added dynamic extension lookup for the libmemcached shared libraries.

I was unable to test if it was correct to also do that for the amd64 architecture, but I assume it's fine.

@ninjudd
Copy link
Owner

ninjudd commented Feb 11, 2014

iOS?

On Mon, Feb 10, 2014 at 11:02 AM, chrisjwu notifications@github.com
wrote:

I added dynamic extension lookup for the libmemcached shared libraries.
I was unable to test if it was correct to also do that for the amd64 architecture, but I assume it's fine.
You can merge this Pull Request by running:
git pull https://github.com/chrisjwu/memcache master
Or you can view, comment on it, or merge it online at:
#22
-- Commit Summary --

@chrisjwu
Copy link
Collaborator Author

Er, I mean OS X, fixed the title.

@ninjudd
Copy link
Owner

ninjudd commented Feb 11, 2014

Looks good to me. @chrisjwu, would you mind separating the duplication out into a function before I merge the pull request?

@chrisjwu
Copy link
Collaborator Author

Done

ninjudd added a commit that referenced this pull request Feb 15, 2014
@ninjudd ninjudd merged commit e322869 into ninjudd:master Feb 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants