Merge pull request #14 from ninoseki/add-refang-support

feat: add defanged IP support
ninoseki · Sep 28, 2019 · 15e810f · 15e810f
2 parents af907ed + 328a8c7
commit 15e810f
Show file tree

Hide file tree

Showing 4 changed files with 73 additions and 1 deletion.
diff --git a/README.md b/README.md
@@ -26,6 +26,11 @@ $ kokki japan
 🇯🇵
 $ kokki 202.214.194.147
 🇯🇵
+# it suports a defanged ip as an input
+$ kokki 1.1.1[.]1
+🇦🇺
+$ kokki "1.1.1(.)1"
+🇦🇺
 ```
 
 ### As a library

diff --git a/lib/kokki/converter.rb b/lib/kokki/converter.rb
@@ -36,8 +36,12 @@ def self.convert(input)
 
     private
 
+    def refang(input)
+      input.gsub("[.]", ".").gsub("(.)", ".")
+    end
+
     def convert_as_ip_address(ip_address)
-      ip = IPAddress.new(ip_address)
+      ip = IPAddress.new(refang(ip_address))
       dict.lookup_by_alpha_2_code ip.country_code
     end
   end

diff --git a/spec/converter_spec.rb b/spec/converter_spec.rb
@@ -41,6 +41,13 @@
       end
     end
 
+    context "when given a defanged ip address" do
+      it do
+        flag = subject.convert("1[.]0[.]16[.]0")
+        expect(flag).to eq("🇯🇵")
+      end
+    end
+
     context "when given an invalid input" do
       it "raises an InvalidError" do
         expect { subject.convert("test") }.to raise_error(Kokki::InvalidInputError)

diff --git a/...tures/vcr_cassettes/Kokki_Converter/_convert/when_given_a_defanged_ip_address/1_1_5_1.yml b/...tures/vcr_cassettes/Kokki_Converter/_convert/when_given_a_defanged_ip_address/1_1_5_1.yml