Skip to content

Commit

Permalink
refactor: use addresses_for
Browse files Browse the repository at this point in the history
Use #addresses_for instead of #query
  • Loading branch information
ninoseki committed Jul 29, 2020
1 parent 713ea06 commit 0034aad
Showing 1 changed file with 6 additions and 10 deletions.
16 changes: 6 additions & 10 deletions lib/rogue_one/detector.rb
Expand Up @@ -137,21 +137,17 @@ def bulk_resolve(resolver, domains)

domains.each do |domain|
semaphore.async do
records = resolver.query(domain, Resolv::DNS::Resource::IN::A).answer.flatten

a_records = records.select do |record|
record.is_a? Resolv::DNS::Resource::IN::A
addresses = []
begin
addresses = resolver.addresses_for(domain, Resolv::DNS::Resource::IN::A, { retries: 1 }).map(&:to_s)
rescue Async::DNS::ResolutionFailure
# do nothing
end

addresses = a_records.map do |record|
record.respond_to?(:address) ? record.address.to_s : nil
end.compact

results << [domain, addresses]
end
end
end
results.to_h.compact
results.to_h
end

def normal_resolver
Expand Down

0 comments on commit 0034aad

Please sign in to comment.