Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: change to follow GitLab's testing best practices #17

Merged
merged 1 commit into from
Sep 30, 2018
Merged

test: change to follow GitLab's testing best practices #17

merged 1 commit into from
Sep 30, 2018

Conversation

ninoseki
Copy link
Owner

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 59

  • 33 of 43 (76.74%) changed or added relevant lines in 11 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.7%) to 96.196%
Changes Missing Coverage Covered Lines Changed/Added Lines %
spec/support/shared_contexts/http_server_shared_context.rb 13 23 56.52%
Totals Coverage Status
Change from base Build 57: -1.7%
Covered Lines: 531
Relevant Lines: 552
💛 - Coveralls

@ninoseki ninoseki merged commit 5fb9bb9 into master Sep 30, 2018
@ninoseki ninoseki deleted the improve-specs branch September 30, 2018 12:12
@ninoseki ninoseki restored the improve-specs branch September 30, 2018 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ninoseki @coveralls