refactor: change to follow the GitLab's testing best practices

see https://docs.gitlab.com/ee/development/testing_guide/best_practices.html

spec/spec_helper.rb

@@ -3,82 +3,25 @@
 require 'coveralls'
 Coveralls.wear!
 
+require 'rack/test'
+
 require_relative '../app/config/environment'
-require 'helpers'
+require_relative "./support/helpers/helpers"
 
-require 'rack/test'
+require_relative "./support/shared_contexts/huntup_shared_context"
+require_relative "./support/shared_contexts/rackapp_shared_context"
+require_relative "./support/shared_contexts/spyup_shared_context"
 
 RSpec.configure do |config|
   config.include Rack::Test::Methods
-  config.include Helpers
+  config.include Spec::Support::Helpers
   config.order = 'default'
   config.shared_context_metadata_behavior = :apply_to_host_groups
-end
 
-# Suppress STDOUT output
-RSpec.configure do |config|
   config.before do
     allow($stdout).to receive(:puts)
   end
-end
-
-def app
-  @app
-end
-
-def mock_app(&builder)
-  @app = Rack::Builder.new(&builder)
-end
-
-RSpec.shared_context "rackapp testing", shared_context: :metadata do
-  before :all do
-    @spyup_log = StringIO.new
-    spyup_logger = LogStashLogger.new(type: :io, io: @spyup_log)
-
-    @huntup_log = StringIO.new
-    huntup_logger = LogStashLogger.new(type: :io, io: @huntup_log)
-
-    mock_app do
-      use Rack::SpyUp do |mw|
-        mw.logger = spyup_logger
-      end
-      use Rack::HuntUp do |mw|
-        mw.logger = huntup_logger
-      end
-      run SleepWarm::Application.new
-    end
-  end
-end
-
-RSpec.shared_context "spyup testing", shared_context: :metadata do
-  before :all do
-    @spyup_log = StringIO.new
-    spyup_logger = LogStashLogger.new(type: :io, io: @spyup_log)
-
-    mock_app do
-      use Rack::SpyUp do |mw|
-        mw.logger = spyup_logger
-      end
-      run SleepWarm::Application.new
-    end
-  end
-end
-
-RSpec.shared_context "huntup testing", shared_context: :metadata do
-  before :all do
-    @huntup_log = StringIO.new
-    huntup_logger = LogStashLogger.new(type: :io, io: @huntup_log)
-
-    mock_app do
-      use Rack::HuntUp do |mw|
-        mw.logger = huntup_logger
-      end
-      run SleepWarm::Application.new
-    end
-  end
-end
 
-RSpec.configure do |config|
   config.include_context "rackapp testing", include_shared: true
   config.include_context "spyup testing", include_shared: true
   config.include_context "huntup testing", include_shared: true

spec/support/helpers/helpers.rb

@@ -0,0 +1,22 @@
+# frozen_string_literal: true
+
+require "json"
+
+module Spec
+  module Support
+    module Helpers
+      def mock_app(&builder)
+        @app = Rack::Builder.new(&builder)
+      end
+
+      def app
+        @app
+      end
+
+      def io_to_queue(io)
+        io.rewind
+        io.readlines.map { |line| JSON.parse line }
+      end
+    end
+  end
+end

spec/support/shared_contexts/huntup_shared_context.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+RSpec.shared_context "huntup testing", shared_context: :metadata do
+  before :all do
+    @huntup_log = StringIO.new
+    huntup_logger = LogStashLogger.new(type: :io, io: @huntup_log)
+
+    mock_app do
+      use Rack::HuntUp do |mw|
+        mw.logger = huntup_logger
+      end
+      run SleepWarm::Application.new
+    end
+  end
+end

spec/support/shared_contexts/rackapp_shared_context.rb

@@ -0,0 +1,21 @@
+# frozen_string_literal: true
+
+RSpec.shared_context "rackapp testing", shared_context: :metadata do
+  before :all do
+    @spyup_log = StringIO.new
+    spyup_logger = LogStashLogger.new(type: :io, io: @spyup_log)
+
+    @huntup_log = StringIO.new
+    huntup_logger = LogStashLogger.new(type: :io, io: @huntup_log)
+
+    mock_app do
+      use Rack::SpyUp do |mw|
+        mw.logger = spyup_logger
+      end
+      use Rack::HuntUp do |mw|
+        mw.logger = huntup_logger
+      end
+      run SleepWarm::Application.new
+    end
+  end
+end

spec/support/shared_contexts/spyup_shared_context.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+RSpec.shared_context "spyup testing", shared_context: :metadata do
+  before :all do
+    @spyup_log = StringIO.new
+    spyup_logger = LogStashLogger.new(type: :io, io: @spyup_log)
+
+    mock_app do
+      use Rack::SpyUp do |mw|
+        mw.logger = spyup_logger
+      end
+      run SleepWarm::Application.new
+    end
+  end
+end