Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working with Marvel's The Punisher #43

Closed
tronyx opened this issue Nov 18, 2017 · 7 comments
Closed

Not working with Marvel's The Punisher #43

tronyx opened this issue Nov 18, 2017 · 7 comments
Labels

Comments

@tronyx
Copy link

tronyx commented Nov 18, 2017

Seems that NowShowing doesn't handle 404 errors from theTVDB very well:

D, [2017-11-18T15:21:38.394907 #70] DEBUG -- : Response from thetvdb for query series/329367/all/en.xml: Code: 404.
E, [2017-11-18T15:21:38.395176 #70] ERROR -- : Could not connect to thetvdb.com. Will retry in 30 seconds
D, [2017-11-18T15:22:08.395416 #70] DEBUG -- : Retry attempt: 1 for query series/329367/all/en.xml
D, [2017-11-18T15:22:08.811694 #70] DEBUG -- : Response from thetvdb for query series/329367/all/en.xml: Code: 404.
E, [2017-11-18T15:22:08.811903 #70] ERROR -- : Could not connect to thetvdb.com. Will retry in 30 seconds
D, [2017-11-18T15:22:38.812429 #70] DEBUG -- : Retry attempt: 2 for query series/329367/all/en.xml
D, [2017-11-18T15:22:39.130871 #70] DEBUG -- : Response from thetvdb for query series/329367/all/en.xml: Code: 404.
E, [2017-11-18T15:22:39.131184 #70] ERROR -- : Could not connect to thetvdb.com. Will retry in 30 seconds

It's looking for Marvel's The Punisher w/ seriesID 329367, which is wrong. The correct ID is 331980. Not sure whether it gets the ID from Plex, which would be weird because Plex has all the right metadata, or just from a search, but it shouldn't just repeatedly fail on a 404. It should retry X times and then move on.

@tronyx tronyx changed the title Not working with Marvel Not working with Marvel's The Punisher Nov 18, 2017
@ninthwalker ninthwalker added the bug label Dec 1, 2017
@ninthwalker
Copy link
Owner

Thanks for the bugreport. It is suppose to only try 3x, then fail out, so I will have to do some testing.

@tronyx
Copy link
Author

tronyx commented Dec 1, 2017

No problem. Let me know if there's anything I can do to help. Also, is it supposed to fail out for that episode after three failures or out of the script entirely?

@ninthwalker
Copy link
Owner

ninthwalker commented Dec 1, 2017 via email

@suckerfish
Copy link

suckerfish commented Dec 7, 2017

fwiw, getting the same thing for Mindhunter. It seems to be querying an invalid ID to tvdb and getting a 404 according to verbose logging but continues to retry. If there is any way to somehow shunt it the correct ID as a temporary workaround, that would be great. Or at the very least, somehow tell it to ignore the show giving the particular problem?

@tronyx
Copy link
Author

tronyx commented Dec 8, 2017

Or at the very least, somehow tell it to ignore the show giving the particular problem?

ninthwalker stated that it's supposed to try three times and then fail, moving on to the next in the list, but there is a bug.

@ninthwalker
Copy link
Owner

I've been a little busy this Month with the holidays. Hope to look into this in January.

@ninthwalker
Copy link
Owner

Closing, fixed in dev version. Will be pushed to prod soon.
Will now correctly try an episode 3x and if not found/errors then will continue on to the next ep.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants