New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deal with aliases #34
Comments
so does this mean, that instead of using the uniq ID i can reference with any of the 'local_addresses'? |
Hello @bittorf, I don't understand very well your question because netdiff itself does not provide a way to reference nodes, maybe that's possible with its dependency, Netdiff does mainly two things: parse network topology data files and compare two topologies to understand what has changed. What is your question about? Is there something you would like to do which now you can't? |
"A node might be referenced one time with an id and another time with one of its aliases. Is this "how it is now" or "how it should be"? |
It's the current situation (how it is now). |
in current master (0.4.5 alpha), we already have the |
@bittorf, in retrospective I think I misunderstood your question back in those days. Now me and @gabriel we believe we should update the NetJSON spec to force referencing nodes only with their IDs and not their aliases, in order to simplify consumer implementations (it's more efficient to let producers handle the mapping as they know better than consumers). |
I also think referencing only IDs is the way to go. Thanks a lot for your work! |
A node might be referenced one time with an id and another time with one of its aliases.
In such a case netdiff would consider the topology changed.
The
local_addresses
attribute was recently introduced in NetJSONNetworkGraph
(see netjson/netjson#15), we can use this feature to work it consistently on all the parsers of the protocols that use aliases.The text was updated successfully, but these errors were encountered: